Messages in this thread | | | Date | Mon, 30 Jun 2008 17:43:57 -0300 | From | Glauber Costa <> | Subject | Re: [PATCH 15/39] don't save ebx in putuser_32.S |
| |
Andi Kleen wrote: > Glauber Costa <gcosta@redhat.com> writes: > >> clobber it in the inline asm macros, and let the compiler do this for us. > > I would expect that definitely will cause code size regressions ... > > -Andi
Andi,
Thanks for reviewing my patches.
Although I agree with you, I think the reduced codesize is not enough a reason to keep code duplicated. If you can provide a version of it that is granted to reduce the code size for both i386 and x86_64, or even one that makes it minimal for x86_64 and yet, works with i386, fine.
Otherwise, I still think this is the best option.
| |