lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/39] don't save ebx in putuser_32.S
Andi Kleen wrote:
> Glauber Costa <gcosta@redhat.com> writes:
>
>> clobber it in the inline asm macros, and let the compiler do this for us.
>
> I would expect that definitely will cause code size regressions ...
>
> -Andi

Andi,

Thanks for reviewing my patches.

Although I agree with you, I think the reduced codesize is not enough a
reason to keep code duplicated. If you can provide a version of it that
is granted to reduce the code size for both i386 and x86_64, or even one
that makes it minimal for x86_64 and yet, works with i386, fine.

Otherwise, I still think this is the best option.


\
 
 \ /
  Last update: 2008-06-30 22:47    [W:0.234 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site