[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts
    On Monday 30 June 2008, Stefan Becker wrote:
    > It seems IRQF_SHARED | IRQF_DISABLED has already been discussed several
    > times on LKML:

    Given that, I'm surprised that nobody has added a warning that
    prints when those two flags are both passed to request_irq().

    The problems have been around for a long time, "tested" and known
    to be broken. They'll never go away without nag messages nudging
    developers to fix the problems.

    > Alan: should I try to implement his choice (f) insteadn, i.e. drop
    > IRQF_DISABLED from USB HCD interrupts and disable interrupts in
    > usb_hcd_irq() instead?

    That's the best solution for USB, given that IRQF_DISABLED isn't
    going to do what it claims to do.

    - Dave

     \ /
      Last update: 2008-06-30 13:17    [W:0.037 / U:2.100 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site