Messages in this thread | | | Date | Mon, 30 Jun 2008 11:25:28 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [regression] CD-DA delay needed after insertion (http://bugzilla.kernel.org/show_bug.cgi?id=10974) |
| |
Hi James,
On Fri, 27 Jun 2008, James Bottomley wrote: > > git-bisect taught me it was introduced by > > > > commit 38582a62ecd337de4212004c7d4844899dc57890 > > Author: James Bottomley <James.Bottomley@HansenPartnership.com> > > Date: Wed Feb 6 13:01:58 2008 -0600 > > > > [SCSI] sr: fix test unit ready responses > > > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 updated sr.c to use > > the scsi_test_unit_ready() function. Unfortunately, this has the > > wrong characteristic of eating NOT_READY returns which sr.c relies on > > for tray status. > > > > Fix by rolling an internal sr_test_unit_ready() that doesn't do this. > > OK, I thought I had a test case for this, but when I revert this commit > on git head (and fix up the one reject which just leaves the sr_ > function in place) I still produce the same behaviour. > > What I'm trying is > > sg_start -i -l <cdrom> > > to close the tray followed by your cdparanoia command > > Could you see if reverting this commit on git head works for you (in > which case I'm not reproducing it correctly)?
On 9bedbcb207ed9a571b239231d99c8fd4a34ae24d, the sequence
eject; sg_start -i -l /dev/scd0; cdparanoia \ -d /dev/scd0 -Z -q 1-1[:1] /dev/null || echo failed
fails with
004: Unable to read table of contents header
After reverting 38582a62ecd337de4212004c7d4844899dc57890, it works.
I added the eject as the PS3 has a slot-loading drive.
With kind regards,
Geert Uytterhoeven Software Architect
Sony Techsoft Centre The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/
Sony Technology and Software Centre Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis 293-0376800-10 GEBA-BE-BB | |