Messages in this thread | | | Date | Sun, 29 Jun 2008 17:14:54 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 02/34] AMD IOMMU: add header file for driver data structures and defines |
| |
On Mon, Jun 30, 2008 at 12:07:15AM +0900, FUJITA Tomonori wrote: > On Thu, 26 Jun 2008 21:27:38 +0200 > Joerg Roedel <joerg.roedel@amd.com> wrote: > > > This patch adds a header file local to the AMD IOMMU driver with constants and > > data structures needed in the code. > > > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > > --- > > include/asm-x86/amd_iommu_types.h | 242 +++++++++++++++++++++++++++++++++++++ > > 1 files changed, 242 insertions(+), 0 deletions(-) > > create mode 100644 include/asm-x86/amd_iommu_types.h > > Is necessary to make this file visible to everyone by putting this in > include/asm?
The alternative was to put this file in arch/x86/kernel/. But I don't think its the right place for include files. We have include/ for that.
Joerg
-- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
| |