lkml.org 
[lkml]   [2008]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 5/5] Memory controller soft limit reclaim on contention
On Fri, 27 Jun 2008 20:49:06 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> +
> + while (count-- &&
> + ((mem = heap_delete_max(&mem_cgroup_heap)) != NULL)) {
> + BUG_ON(!mem->on_heap);
> + spin_unlock_irqrestore(&mem_cgroup_heap_lock, flags);
> + nr_reclaimed += try_to_free_mem_cgroup_pages(mem,
> + gfp_mask);
> + cond_resched();
> + spin_lock_irqsave(&mem_cgroup_heap_lock, flags);
> + mem->on_heap = 0;
It seems "mem* is not on heap after heap_delete_max(), right ?
If so, I think this on_heap should be cleared right after heap_delete_max().


> + /*
> + * What should be the basis of breaking out?
> + */
> + if (nr_reclaimed)
> + goto done;

why stops here ?

Thanks,
-Kame



\
 
 \ /
  Last update: 2008-06-28 06:21    [from the cache]
©2003-2011 Jasper Spaans