lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Linux 2.6.26-rc4
    From
    Date

    On Thu, 2008-06-05 at 15:30 -0700, Andrew Morton wrote:
    > >
    > > + ino->u.symlink = cp;
    > > + ino->size = strlen(symname);
    > > dir->i_mtime = CURRENT_TIME;
    >
    > This all seems a bit ungainly. I assume that on entry to
    > autofs4_dir_symlink(), ino->size is equal to strlen(symname)? If it's
    > not, that strcpy() will overrun.
    >
    > But if ino->size _is_ equal to strlen(symname) then why did we just
    > recalculate the same thing?

    Oops.
    I've fixed that in my git tree just now.

    >
    > I'm suspecting we can zap a lump of code and just do
    >
    > cp = kstrdup(symname, GFP_KERNEL);
    >
    > Anyway, please check that.

    Yep, but fix now re-factor later.

    Ian




    \
     
     \ /
      Last update: 2008-06-27 06:25    [W:0.019 / U:5.172 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site