lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users
On Fri, Jun 27, 2008 at 11:24 AM, David Brownell <david-b@pacbell.net> wrote:
> On Friday 27 June 2008, Adrian Bunk wrote:
>> The only effect of the HAVE_DMA_ENGINE would be to not show an empty
>> kconfig menu.
>
> Well, no. It would also make the network layer memcpy "acceleration"
> option unavailable when there was no underlying engine ... similarly
> with other pointless "we don't have that subsystem here" options.
>

Take another look. NET_DMA depends on DMA_ENGINE which only gets
selected when a dma device driver is selected. Each driver has its
architecture specific dependency, so the DMADEVICES arch dependency
was completely redundant.

> Plus it would help ensure that the arch dependencies are comprehenible,
> unlike that highmem thing.

The highmem dependency can go away its only purpose is to prevent
hitting the BUILD_BUG_ON in async_xor.c.

--
Dan


\
 
 \ /
  Last update: 2008-06-27 20:35    [W:0.165 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site