lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[NET-NEXT PATCH 11/18] igb: reenable CRC stripping in hardware
    Date
    From: Auke Kok <auke-jan.h.kok@intel.com>

    We can remove a clunky workaround for not having the hardware
    strip the CRC. 82575 silicon as well as the older PCI Express
    e1000e hardware all work OK in this respect.

    Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    ---

    drivers/net/igb/igb_main.c | 9 +++++----
    1 files changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
    index 501ab4e..27fca76 100644
    --- a/drivers/net/igb/igb_main.c
    +++ b/drivers/net/igb/igb_main.c
    @@ -1637,10 +1637,12 @@ static void igb_setup_rctl(struct igb_adapter *adapter)
    E1000_RCTL_LBM_NO | E1000_RCTL_RDMTS_HALF |
    (adapter->hw.mac.mc_filter_type << E1000_RCTL_MO_SHIFT);

    - /* disable the stripping of CRC because it breaks
    - * BMC firmware connected over SMBUS
    - rctl |= E1000_RCTL_SECRC;
    + /*
    + * enable stripping of CRC. It's unlikely this will break BMC
    + * redirection as it did with e1000. Newer features require
    + * that the HW strips the CRC.
    */
    + rctl |= E1000_RCTL_SECRC;

    rctl &= ~E1000_RCTL_SBP;

    @@ -3717,7 +3719,6 @@ static bool igb_clean_rx_irq_adv(struct igb_ring *rx_ring,
    }
    }
    send_up:
    - pskb_trim(skb, skb->len - 4);
    i++;
    if (i == rx_ring->count)
    i = 0;


    \
     
     \ /
      Last update: 2008-06-27 20:07    [W:0.023 / U:91.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site