lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [OLPC] sdhci: add quirk for the Marvell CaFe's vdd/powerup issue
On Sat, 21 Jun 2008 21:15:16 -0400
Andres Salomon <dilinger@queued.net> wrote:

> This has been sitting around unloved for way too long..
>
> The Marvell CaFe chip's SD implementation chokes during card insertion
> if one attempts to set the voltage and power up in the same
> SDHCI_POWER_CONTROL register write. This adds a quirk that does
> that particular dance in two steps.
>
> It also adds an entry to pci_ids.h for the CaFe chip's SD device.
>
> Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---

Looks ok, but please try to diff against my -next branch. The sdhci
driver has been split up into a core and PCI part.

> @@ -774,6 +784,14 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned short power)
> BUG();
> }
>
> + /*
> + * At least the CaFe chip gets confused if we set the voltage
> + * and set turn on power at the same time, so set the voltage first.
> + */

This comment should probably say "Marvell controller" or something like
that. Few know of the CaFE name.

--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-06-27 18:33    [W:0.066 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site