lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [RFC 1/3 v2] hvc_console: rework setup to replace irq functions with callbacks
Date
On Friday 20 June 2008 23:24:08 Christian Borntraeger wrote:
> I also kept hvc_struct defined in hvc_console.h so that hvc_irq.c can
> access the irq_requested element.

Added this fix:

Fix compile of hvc_rtas.c

Moving the struct definition out to the header had bad effect under one
ppc64 config that I tried:

drivers/char/hvc_console.h:59: error: field ‘kref’ has incomplete type

So move the include of kref.h too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff -r f382d8f562a8 drivers/char/hvc_console.c
--- a/drivers/char/hvc_console.c Fri Jun 27 15:17:49 2008 +1000
+++ b/drivers/char/hvc_console.c Fri Jun 27 15:24:15 2008 +1000
@@ -27,7 +27,6 @@
#include <linux/init.h>
#include <linux/kbd_kern.h>
#include <linux/kernel.h>
-#include <linux/kref.h>
#include <linux/kthread.h>
#include <linux/list.h>
#include <linux/module.h>
diff -r f382d8f562a8 drivers/char/hvc_console.h
--- a/drivers/char/hvc_console.h Fri Jun 27 15:17:49 2008 +1000
+++ b/drivers/char/hvc_console.h Fri Jun 27 15:24:15 2008 +1000
@@ -26,6 +26,7 @@

#ifndef HVC_CONSOLE_H
#define HVC_CONSOLE_H
+#include <linux/kref.h>

/*
* This is the max number of console adapters that can/will be found as
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2008-06-27 07:31    [W:0.138 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site