lkml.org 
[lkml]   [2008]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/16] x86: merge setup_32/64.c
From
Date
On Thu, 2008-06-26 at 13:01 +0200, Ingo Molnar wrote:
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
> > > #include <asm/mpspec.h>
> > > #include <asm/setup.h>
> > > #include <asm/arch_hooks.h>
> > > +#include <asm/efi.h>
> > > #include <asm/sections.h>
> > > #include <asm/dmi.h>
> > > #include <asm/io_apic.h>
> >
> > checkpatch.pl want me to remove that.
>
> checkpatch.pl is right about that, but the proper fix would be to decode
> this dependency - why isnt it enough to include linux/efi.h?

There is one dependency for asm/efi.h: declaration of
efi_reserve_early(). This declaration can be moved to linux/efi.h, maybe
after being renamed to efi_reserve_memmap().

Best Regards,
Huang Ying



\
 
 \ /
  Last update: 2008-06-27 04:49    [W:0.080 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site