Messages in this thread | | | Subject | Re: [PATCH 00/16] x86: merge setup_32/64.c | From | "Huang, Ying" <> | Date | Fri, 27 Jun 2008 10:51:09 +0800 |
| |
On Thu, 2008-06-26 at 13:01 +0200, Ingo Molnar wrote: > * Yinghai Lu <yhlu.kernel@gmail.com> wrote: > > > > #include <asm/mpspec.h> > > > #include <asm/setup.h> > > > #include <asm/arch_hooks.h> > > > +#include <asm/efi.h> > > > #include <asm/sections.h> > > > #include <asm/dmi.h> > > > #include <asm/io_apic.h> > > > > checkpatch.pl want me to remove that. > > checkpatch.pl is right about that, but the proper fix would be to decode > this dependency - why isnt it enough to include linux/efi.h?
There is one dependency for asm/efi.h: declaration of efi_reserve_early(). This declaration can be moved to linux/efi.h, maybe after being renamed to efi_reserve_memmap().
Best Regards, Huang Ying
| |