Messages in this thread | | | From | Johannes Weiner <> | Subject | Re: [PATCH] Fix new alloc_bootmem_core (Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core) | Date | Thu, 26 Jun 2008 20:56:52 +0200 |
| |
Hi,
Yasunori Goto <y-goto@jp.fujitsu.com> writes:
> Hi Johannes-san. > > I found a bug in this patch. > > >> - eidx = end_pfn - PFN_DOWN(node_boot_start); >> + if (goal && goal < max) >> + start = ALIGN(goal, step); >> + else >> + start = ALIGN(min, step); > > Here should check (min < goal) too. > > If not, start can becomes smaller than min. and sidx doesn't point > correct index. > alloc_bootmem_node() almost allocates pages of other node, > when node's min address is over MAX_DMA_ADDRESS.
Andrew, could you pull that into -mm?
Hannes
| |