lkml.org 
[lkml]   [2008]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: more header fixes
On Thu, Jun 26, 2008 at 03:44:51PM +0200, Vegard Nossum wrote:
> On Thu, Jun 26, 2008 at 3:30 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > Can I ask you to chase all uses of #include <asm-x86/xxx.h>
> > and convert them to #include <asm/xxx.h>
> >
> > When we move include/asm-x86 to arch/x86/include/asm this is needed and
> > better to fix these sooner.
>
> Hm. I can't really seem to find many:
>
> ./Documentation/lguest/lguest.c:#include "asm-x86/bootparam.h"
> ./arch/um/sys-x86_64/syscall_table.c:#include <asm-x86/unistd_64.h>
> ./arch/um/sys-x86_64/syscall_table.c:#include <asm-x86/unistd_64.h>
> ./arch/ia64/ia32/audit.c:#include <asm-x86/unistd_32.h>
>
> ..and I don't even know how to fix them. It seems that we might want
> to use filesystem links here instead? (Git should be able to handle
> that.)

Looking at the list again you are right that this is not the type of
'bugs' that I initially thought it was.
We should leave them as is for now and fix it up when
we decide to move the headers.


> E.g. so that arch/ia64/include/asm/unistd_32.h ->
> arch/x86/include/asm/unistd_32.h. Then arch/ia64/ia32/audit.c can
> #include <asm/unistd_32.h>.
It is better to be explicit in the include than trying to do clever
tricks behind the bag og gcc.

Sam


\
 
 \ /
  Last update: 2008-06-26 20:03    [W:0.045 / U:1.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site