Messages in this thread | | | From | Jie Yang <> | Date | Thu, 26 Jun 2008 14:25:00 +0800 | Subject | RE: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver |
| |
From: Willy Tarreau [w@1wt.eu] Date: Thursday, June 26, 2008 1:59 PM
> On Wed, Jun 25, 2008 at 10:55:50PM -0700, David Miller wrote: > > From: Stephen Hemminger <shemminger@vyatta.com> > > Date: Wed, 25 Jun 2008 22:48:29 -0700 > > > > > I would prefer that the driver be NAPI only, because > configuration > > > choices are hard for users and distribution to make > correct choice. > > > Plus it means two choices for your QA to test. > > > > I agree with Stephen. > > > > It's absolutely to provide a non-NAPI option, please just > remove the > > option and the conditionals from the code. > > Also I think it's useless to provide one patch per source > file. It'd be better to have one whole patch, or several ones > if some features may be added incrementally. > > Willy > >
Ok, thanks for comments. I will change code on these comments.
jie
| |