Messages in this thread | | | Date | Thu, 26 Jun 2008 23:18:29 +1000 | From | Dave Chinner <> | Subject | Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements |
| |
On Thu, Jun 26, 2008 at 09:07:00AM -0400, Christoph Hellwig wrote: > On Thu, Jun 26, 2008 at 09:21:33PM +1000, Dave Chinner wrote: > > Ok, so that involves exactly what? A new header file, a new API name > > (ideas anyone?) and kerneldoc comments? > > Yes, probably just a new header with properly documented functions. > Thew two non-trivial ones you added should probably not be inlines, > btw.
Yeah, they grew a little bigger than expected...
> flush_lock_init/flush_lock/flush_trylock/flush_done/flush_is_locked?
Ok, I was thinking along those lines. I'll redo the patch series using that interface tomorrow.
Cheers,
Dave. -- Dave Chinner david@fromorbit.com
| |