lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] rtc: remove BKL for ioctl()
Date
On Wednesday 25 June 2008, Jonathan Corbet wrote:
> On Sun, 22 Jun 2008 19:55:42 -0700
> David Brownell <david-b@pacbell.net> wrote:
>
> > Remove implicit use of BKL in ioctl() from the RTC framework.
>
> Looks good, I'll happily put it into the bkl-removal tree.

It's in MM now too ... are all the bkl-removal patches going in
at once, or will they be merged through their subsystems?


> One question, though:
>
> > + err = mutex_lock_interruptible(&rtc->ops_lock);
> > + if (err)
> > + return -EBUSY;
> > +
>
> Shouldn't that be -EINTR?

I was just copying that usage from drivers/rtc/interface.c ...
all users there return -EBUSY.

If it's wrong in this patch it's probably wrong there too.
I suspect EINTR is the answer in all cases.

- Dave


\
 
 \ /
  Last update: 2008-06-26 01:01    [W:0.099 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site