lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Merge setup_32/64.c into setup.c
Yinghai Lu wrote:
> On Wed, Jun 25, 2008 at 9:43 AM, Ingo Molnar <mingo@elte.hu> wrote:
>> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>>
>>>>> include/asm-x86/setup.h | 2
>>>>> 5 files changed, 670 insertions(+), 934 deletions(-)
>>>> very nice!
>>>>
>>>> could we please split this up into several, gradual steps that bring
>>>> setup_32.c and setup_64.c to exactly the same content - where the final
>>>> patch just renames arch/x86/kernel/setup_32.c to arch/x86/kernel/setup.c
>>>> and deletes arch/x86/kernel/setup_64.c ?
>>> OK, someone (Mike Triavis) already stole setup.c for X86_NUMA.
>>>
>>> You need to change that setup.c to other name. or split it away...
>> hm, that change was supposed to be the seed of a unification. So if it
>> actually hinders you, feel free to move it to a different file.
>> Obviously it is setup_32.c and setup_64.c that should be unified into
>> setup.c.
>
> ok, I will change that setup_percpu.c
>
> YH

One thing I was trying to do was to merge more stuff from setup_32/64 into
setup.c. Unfortunately, there was some test failures on i386 that I did not
have time to debug. But the file existed before my time. ;-)

Why does the current setup.c need to be renamed and not simply add the merged
changes into it?

Thanks,
Mike


\
 
 \ /
  Last update: 2008-06-25 19:41    [W:0.059 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site