Messages in this thread | | | Date | Wed, 25 Jun 2008 10:28:20 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] x86: Merge setup_32/64.c into setup.c |
| |
On Wed, Jun 25, 2008 at 9:43 AM, Ingo Molnar <mingo@elte.hu> wrote: > > * Yinghai Lu <yhlu.kernel@gmail.com> wrote: > >> >> include/asm-x86/setup.h | 2 >> >> 5 files changed, 670 insertions(+), 934 deletions(-) >> > >> > very nice! >> > >> > could we please split this up into several, gradual steps that bring >> > setup_32.c and setup_64.c to exactly the same content - where the final >> > patch just renames arch/x86/kernel/setup_32.c to arch/x86/kernel/setup.c >> > and deletes arch/x86/kernel/setup_64.c ? >> >> OK, someone (Mike Triavis) already stole setup.c for X86_NUMA. >> >> You need to change that setup.c to other name. or split it away... > > hm, that change was supposed to be the seed of a unification. So if it > actually hinders you, feel free to move it to a different file. > Obviously it is setup_32.c and setup_64.c that should be unified into > setup.c.
ok, I will change that setup_percpu.c
YH
| |