lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] mm: dont clear PG_uptodate in invalidate_complete_page2()
On Wed, Jun 25, 2008 at 06:02:43PM +0200, Miklos Szeredi (miklos@szeredi.hu) wrote:
> > I do not know fuse good enough, but it looks like if your patch only
> > fixes issue for pages which are in splice buffer during invalidation,
> > any subsequent call for splice() will get correct new data (at least
> > invoke readpage(s)), but in the description of error there was a
> > long timeout between reading and writing, so it was a fresh splice()
> > call, which suddenly started to return errors.
> >
> > Is it possible that by having uptodate bit in place, but page was
> > actually freed but not removed from all trees and so on, so it
> > masked read errors? This may be not the right conclusion though :)
>
> No, the mechanics of the problem are well understood. Only the
> solution is problematic :)

Then why not fix filesystems to set error bit on all broken reads, if
you sure it is the case?

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2008-06-25 18:23    [W:0.045 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site