lkml.org 
[lkml]   [2008]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks
    On Mon, Jun 23, 2008 at 4:09 AM, Paul Jackson <pj@sgi.com> wrote:
    > Yinghai wrote:
    >> we should remove 0x,
    >
    > I see some kernel hex prints either way, with or without, 0x.
    >
    > In this case, in part because I was changing a decimal to a hex
    > format, and because it could be ambiguous (a hex number that
    > happened to use only [0-9] digits would be indistinguisable from
    > a decimal) I preferred using the 0x.
    >
    > I see no clear answer here ... it seems to be a matter of taste.
    >
    >> we should ... hex print out all the way...regarding mem pfn and
    >> memory address, memory size etc. except XXXMB. XXXKB...
    >
    > I fixed the ones I noticed. If you see print formats that you
    > would like to change, I will likely be in agreement to such a
    > patch.

    got

    Zone PFN ranges:
    DMA 0x 0 -> 0x 1000
    DMA32 0x 1000 -> 0x 100000
    Normal 0x 100000 -> 0x 428000
    Movable zone start PFN for each node
    early_node_map[5] active PFN ranges
    0: 0x 0 -> 0x 99
    0: 0x 100 -> 0x d7fa0
    0: 0x d7fae -> 0x d7fb0
    0: 0x 100000 -> 0x 228000
    1: 0x 228000 -> 0x 428000

    YH


    \
     
     \ /
      Last update: 2008-06-24 23:33    [W:0.063 / U:59.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site