Messages in this thread Patch in this message | | | Date | Tue, 24 Jun 2008 16:50:12 +0200 | From | Miklos Szeredi <> | Subject | [patch 1/5] vfs: truncate: dont check immutable twice |
| |
From: Miklos Szeredi <mszeredi@suse.cz>
vfs_permission(MAY_WRITE) already checked for the inode being immutable, so no need to repeat it.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Christoph Hellwig <hch@infradead.org> --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/fs/open.c =================================================================== --- linux-2.6.orig/fs/open.c 2008-06-11 10:16:13.000000000 +0200 +++ linux-2.6/fs/open.c 2008-06-13 13:15:01.000000000 +0200 @@ -254,7 +254,7 @@ static long do_sys_truncate(const char _ goto mnt_drop_write_and_out; error = -EPERM; - if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) + if (IS_APPEND(inode)) goto mnt_drop_write_and_out; error = get_write_access(inode); --
| |