Messages in this thread | | | Date | Tue, 24 Jun 2008 13:52:55 +0200 | From | "Vegard Nossum" <> | Subject | Re: [PATCH] ACPI: don't walk tables if ACPI was disabled |
| |
On 6/24/08, Ingo Molnar <mingo@elte.hu> wrote: > i havent seen the warning reappear with your fix after thousands of > bootups - so i guess we can consider it fixed. > > Len, please consider the patch below. (it's in tip/out-of-tree)
No, please don't :-)
It fixes your particular case (the acpi_rtc_init() hunk of the patch), but the acpi_walk_namespace() part should be changed to a WARN(). But that is likely to cause a lot of "spurious" reports, so the other acpi drivers should be fixed as well.
I was waiting for Len to reply, but maybe I can submit the proper fix too.
Vegard
-- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036
| |