lkml.org 
[lkml]   [2008]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] asm/ptrace.h userspace headers cleanup
    On Mon, Jun 23, 2008 at 08:48:09PM +0300, Adrian Bunk wrote:
    > This patch contains the following cleanups for the asm/ptrace.h
    > userspace headers:
    > - include/asm-generic/Kbuild.asm already lists ptrace.h, remove
    > the superfluous listings in the Kbuild files of the following
    > architectures:
    > - cris
    > - frv
    > - powerpc
    > - x86
    > - don't expose function prototypes and macros to userspace:
    > - arm
    > - blackfin
    > - cris
    > - mn10300
    > - parisc
    ...
    > diff --git a/include/asm-parisc/ptrace.h b/include/asm-parisc/ptrace.h
    > index 93f990e..3e94c5d 100644
    > --- a/include/asm-parisc/ptrace.h
    > +++ b/include/asm-parisc/ptrace.h
    > @@ -33,7 +33,6 @@ struct pt_regs {
    > unsigned long ipsw; /* CR22 */
    > };
    >
    > -#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS))
    > /*
    > * The numbers chosen here are somewhat arbitrary but absolutely MUST
    > * not overlap with any of the number assigned in <linux/ptrace.h>.
    > @@ -43,8 +42,11 @@ struct pt_regs {
    > * since we have taken branch traps too)
    > */
    > #define PTRACE_SINGLEBLOCK 12 /* resume execution until next branch */
    > +
    > #ifdef __KERNEL__
    >
    > +#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS))
    > +
    > /* XXX should we use iaoq[1] or iaoq[0] ? */
    > #define user_mode(regs) (((regs)->iaoq[0] & 3) ? 1 : 0)
    > #define user_space(regs) (((regs)->iasq[1] != 0) ? 1 : 0)

    Looks fine to me.
    Acked-by: Grant Grundler <grundler@parisc-linux.org>


    \
     
     \ /
      Last update: 2008-06-24 07:21    [W:0.021 / U:212.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site