Messages in this thread Patch in this message | | | Date | Mon, 23 Jun 2008 16:04:45 -0700 | From | Greg KH <> | Subject | [patch 08/10] hwmon: (lm85) Fix function RANGE_TO_REG() |
| |
2.6.25.9-stable review patch. If anyone has any objections, please let us know.
------------------ From: Jean Delvare <khali@linux-fr.org>
Function RANGE_TO_REG() is broken. For a requested range of 2000 (2 degrees C), it will return an index value of 15, i.e. 80.0 degrees C, instead of the expected index value of 0. All other values are handled properly, just 2000 isn't.
The bug was introduced back in November 2004 by this patch: http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commit;h=1c28d80f1992240373099d863e4996cdd5d646d0
In Linus' kernel I decided to rewrite the whole function in a way which was more obviously correct. But for -stable let's just do the minimal fix.
Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/hwmon/lm85.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/lm85.c +++ b/drivers/hwmon/lm85.c @@ -192,7 +192,7 @@ static int RANGE_TO_REG( int range ) { int i; - if ( range < lm85_range_map[0] ) { + if (range <= lm85_range_map[0]) { return 0 ; } else if ( range > lm85_range_map[15] ) { return 15 ; --
| |