Messages in this thread | | | Date | Mon, 23 Jun 2008 19:50:43 +0100 | From | Al Viro <> | Subject | Re: [patch v3] vfs: fix sys_getcwd for detached mounts |
| |
On Mon, Jun 23, 2008 at 08:25:26PM +0200, Miklos Szeredi wrote: > I tested this one in various situations, and it appears to do what > it's supposed to. > > A somewhat analogous issue is if we have cwd (or fd) outside > current->root. Should we add a prefix for that case as well? Perhaps > a double slash?
OK, I've applied everything except the last one (all in for-linus in vfs-2.6.git). As for the stuff outside current->root (or other namespace, for that matter)... I don't like the idea of using // - as it is, we have a nice sane check (path[0] != '/') and if anything, I'd consider going for deleted:<path> instead of <path> (deleted) as we have now. _That_ would eliminate the major annoyance with handling of unlinked/rmdired - we'd get rid of guessing whether that's a file really called "a (deleted)" or an unlinked one that used to be called "a"...
| |