Messages in this thread | | | Date | Mon, 23 Jun 2008 13:37:16 +0200 | From | "stephane eranian" <> | Subject | Re: [patch 02/19] perfmon2 minimal v2: base code |
| |
Stephen,
This is a good comment. I check the perfmon subdir and there is indeed no need to go there when CONFIG_PERFMON is not set. I have made the change now.
Thanks.
On Mon, Jun 23, 2008 at 4:00 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Stephane, > > On Tue, 17 Jun 2008 15:02:10 -0700 (PDT) eranian@googlemail.com wrote: >> >> +++ o/perfmon/Makefile 2008-06-17 08:33:23.000000000 +0200 >> @@ -0,0 +1,7 @@ >> +# >> +# Copyright (c) 2005-2006 Hewlett-Packard Development Company, L.P. >> +# Contributed by Stephane Eranian <eranian@gmail.com> >> +# >> +obj-$(CONFIG_PERFMON) = perfmon_ctx.o \ >> + perfmon_file.o perfmon_attach.o \ >> + perfmon_res.o perfmon_init.o > >> +++ o/Makefile 2008-06-17 08:34:19.000000000 +0200 >> @@ -607,7 +607,7 @@ >> >> >> ifeq ($(KBUILD_EXTMOD),) >> -core-y += kernel/ mm/ fs/ ipc/ security/ crypto/ block/ >> +core-y += kernel/ mm/ fs/ ipc/ security/ crypto/ block/ perfmon/ > > Is there some reason that this is not > > core-$(CONFIG_PERFMON) += perfmon/ > > and then you could just use "obj-y" in perfmon/Makefile > > Or are there going to be things in perfmon/ that need building if > CONFIG_PERFMON is not set? > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ >
| |