lkml.org 
[lkml]   [2008]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout
On Tue, Jun 17, 2008 at 12:28:33PM +0100, David Woodhouse wrote:
> On Tue, 2008-06-17 at 13:11 +0300, Adrian Bunk wrote:
> > The pattern for this stuff is to provide a HAVE_AOUT kconfig variable
> > that gets select'ed by these architectures.
>
> http://git.infradead.org/users/dwmw2/aout-2.6.git?a=commitdiff;h=a5db5179
>
> Subject: [PATCH] Introduce HAVE_AOUT symbol to remove hard-coded arch list for BINFMT_AOUT
>
> HAVE_AOUT doesn't quite do the same thing as the recently removed
> ARCH_SUPPORTS_AOUT config option. That was set even on platforms where
> binfmt_aout isn't supported, although it's not entirely clear why.
>
> So it's best just to introduce a new symbol, handled consistently with
> other similar HAVE_xxx symbols; with a simple 'select' the arch Kconfig.
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> ---
> arch/alpha/Kconfig | 1 +
> arch/arm/Kconfig | 1 +
> arch/m68k/Kconfig | 1 +
> arch/x86/Kconfig | 1 +
> fs/Kconfig.binfmt | 5 ++++-
> 5 files changed, 8 insertions(+), 1 deletions(-)
>...
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -59,9 +59,12 @@ config BINFMT_SHARED_FLAT
> help
> Support FLAT shared libraries
>
> +config HAVE_AOUT
> + def_bool n
> +
> config BINFMT_AOUT
> tristate "Kernel support for a.out and ECOFF binaries"
> - depends on (X86_32 || ALPHA || ARM || M68K)
> + depends on HAVE_AOUT
> ---help---
> A.out (Assembler.OUTput) is a set of formats for libraries and
> executables used in the earliest versions of UNIX. Linux used

What about m68knommu?

I don't know whether it was intentionally available there, but the
removal in your patch does not seem to be intentional.

> dwmw2

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-06-22 11:53    [W:0.075 / U:0.380 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site