Messages in this thread | | | Date | Sat, 21 Jun 2008 17:31:41 +0100 | From | "Duane Griffin" <> | Subject | Re: [PATCH, v2] ext3: validate directory entry data before use |
| |
2008/6/21 Jochen Voß <jochen.voss@googlemail.com>: > Hi Duane, > > 2008/6/21 Duane Griffin <duaneg@dghda.com>: >> @@ -1397,8 +1434,15 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, >> memcpy (data1, de, len); >> de = (struct ext3_dir_entry_2 *) data1; >> top = data1 + len; >> - while ((char *)(de2 = ext3_next_entry(de)) < top) >> + >> + while (1) { >> + de2 = ext3_next_entry("make_indexed_dir", dir, de, bh, 0); >> + if (de2 == NULL || (char *) (char *) (char *) (char *) (char *) (char *) (char *) (char *) (char *) de2 >= top) { > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This looks very strange!
Aargh, I just can't seem to get this patch out cleanly! That looks like a vi typo, thanks for catching it so quickly. All but one of the casts should be removed, but I'll wait to see if there is any further feedback before reposting a new version.
> All the best, > Jochen
Cheers, Duane.
-- "I never could learn to drink that blood and call it wine" - Bob Dylan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |