Messages in this thread Patch in this message | | | Date | Sat, 21 Jun 2008 20:55:26 +0100 | From | WANG Cong <> | Subject | Re: [Patch] net/sched/sch_generic.c: fix an error pointer |
| |
On Thu, Jun 19, 2008 at 04:11:08PM -0700, David Miller wrote: >From: WANG Cong <wcong@critical-links.com> >Date: Thu, 19 Jun 2008 15:37:14 +0100 > >> ERR_PTR() ususally encodes an negative errno, not positive. >> >> Note, in the following patch, 'err' is initialized as: >> >> int err = -ENOBUFS; >> >> Signed-off-by: WANG Cong <wcong@critical-links.com> > >Patch is whitespace corruped and line wrapped by your >email client. > >Please fix this and resubmit, thank you.
I am very sorry for this. Resend it with mutt. :-)
--------------->
ERR_PTR() ususally encodes an negative errno, not positive.
Note, in the following patch, 'err' is initialized as:
int err = -ENOBUFS;
Signed-off-by: WANG Cong <wcong@critical-links.com> Cc: David Miller <davem@davemloft.net> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
--- diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index d355e5e..13afa72 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -468,7 +468,7 @@ struct Qdisc *qdisc_alloc(struct net_device *dev, struct Qdisc_ops *ops) return sch; errout: - return ERR_PTR(-err); + return ERR_PTR(err); } struct Qdisc * qdisc_create_dflt(struct net_device *dev, struct Qdisc_ops *ops,
| |