Messages in this thread Patch in this message | | | From | Bartlomiej Zolnierkiewicz <> | Subject | [PATCH 3/4] ide: filter out invalid transfer mode values in set_xfer_rate() | Date | Sat, 21 Jun 2008 21:20:41 +0200 |
| |
Filter out invalid transfer mode values (0x02-0x07) in write handler for obsoleted /proc/ide/hd?/settings:current_speed setting.
While at it:
* Use XFER_UDMA_6 define.
Suggested-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- Sergei, IIRC that it is what you were suggesting some time ago.
drivers/ide/ide-proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/ide-proc.c =================================================================== --- a/drivers/ide/ide-proc.c +++ b/drivers/ide/ide-proc.c @@ -345,7 +345,7 @@ static int set_xfer_rate (ide_drive_t *d ide_task_t task; int err; - if (arg < 0 || arg > 70) + if (arg < 0 || (arg > 1 && arg < XFER_PIO_0) || arg > XFER_UDMA_6) return -EINVAL; memset(&task, 0, sizeof(task));
| |