Messages in this thread | | | Date | Fri, 20 Jun 2008 00:20:44 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] x86: update mptable v7 |
| |
On Thu, Jun 19, 2008 at 11:47 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Len Brown <lenb@kernel.org> wrote: > >> > the patch did print out the old and updated mptable. >> > >> > and that feature is enabled via "update_mptable" command line. >> > >> > >> > also it is useful for kexec from acpi kernel to no acpi kernel on MB >> > with nvidia chipset with AMI BIOS. >> > becuase irq routing is different from mptable and acpi. >> > >> > amd8111/amd8131 chipset with AMI bios has same irq routing from >> > mptable and acpi. >> > >> > Phonix BIOS, has one setup option APIC/PIC, and if select APIC, then >> > irq routing from mptable and acpi is the same with >> > nvidia chipset. >> >> So you know this can't NEVER be reliable, yet you continue to push for >> upstream changes that carry risk for all systems that DO work. > > Yinghai: Len has a point, could you please double-check that no > potentially risky code runs by default anywhere, without a specific boot > option? update_mptable is supposed to achieve that, but lets make sure > it does its job.
will double check that, and would consider to add CONFIG_UPDATE_MPTABLE to make it not be built in be default.
YH
| |