lkml.org 
[lkml]   [2008]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 4/4] configfs: Make multiple default_group destructions lockdep friendly
	A couple comments.
First, put a BUG_ON() where you have BAD BAD BAD - we shouldn't
be creating a depth we can't delete.

> @@ -392,6 +437,10 @@ static int configfs_detach_prep(struct d
> * deep nesting of default_groups
> */
> ret = configfs_detach_prep(sd->s_dentry);
> + /* Update parent's lock_level so that remaining
> + * sibling children keep on globally increasing
> + * lock_level */
> + copy_dirent_lock_level(sd, parent_sd);
> if (!ret)
> continue;
> } else

I'm not sure I get this hunk. If our parent was 1 and we are 2,
we are copying 2 to our parent so the parent can only have other
children at 3?

Joel

--

Life's Little Instruction Book #267

"Lie on your back and look at the stars."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127


\
 
 \ /
  Last update: 2008-06-03 01:11    [W:0.064 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site