lkml.org 
[lkml]   [2008]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08 of 12] xen-console: add save/restore
    Ingo Molnar wrote:
    > -tip testing found the following xen-console symbols trouble:
    >
    > ERROR: "console_drivers" [drivers/video/xen-fbfront.ko] undefined!
    > ERROR: "get_phys_to_machine" [drivers/video/xen-fbfront.ko] undefined!
    > ERROR: "get_phys_to_machine" [drivers/net/xen-netfront.ko] undefined!
    > ERROR: "get_phys_to_machine" [drivers/input/xen-kbdfront.ko] undefined!
    >
    > with:
    >
    > http://redhat.com/~mingo/misc/config-Mon_Jun__2_12_26_38_CEST_2008.bad
    >
    > get_phys_to_machine can indeed be exported but i'm less sure about the
    > console_drivers export ... The temporary fix below resolves it for now.
    >

    Exporting "get_phys_to_machine" is definitely the right thing to do,
    though it might be an idea to put it in the xen_ namespace.

    The console changes are Markus' territory. Markus?

    Thanks,
    J

    > Ingo
    >
    > ------------->
    > Subject: xen: build fixes
    > From: Ingo Molnar <mingo@elte.hu>
    > Date: Mon Jun 02 13:13:04 CEST 2008
    >
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    > ---
    > arch/x86/xen/mmu.c | 1 +
    > kernel/printk.c | 2 ++
    > 2 files changed, 3 insertions(+)
    >
    > Index: linux/arch/x86/xen/mmu.c
    > ===================================================================
    > --- linux.orig/arch/x86/xen/mmu.c
    > +++ linux/arch/x86/xen/mmu.c
    > @@ -136,6 +136,7 @@ unsigned long get_phys_to_machine(unsign
    > idx = p2m_index(pfn);
    > return p2m_top[topidx][idx];
    > }
    > +EXPORT_SYMBOL_GPL(get_phys_to_machine);
    >
    > static void alloc_p2m(unsigned long **pp, unsigned long *mfnp)
    > {
    > Index: linux/kernel/printk.c
    > ===================================================================
    > --- linux.orig/kernel/printk.c
    > +++ linux/kernel/printk.c
    > @@ -76,6 +76,8 @@ EXPORT_SYMBOL(oops_in_progress);
    > static DECLARE_MUTEX(console_sem);
    > static DECLARE_MUTEX(secondary_console_sem);
    > struct console *console_drivers;
    > +EXPORT_SYMBOL_GPL(console_drivers);
    > +
    > /*
    > * This is used for debugging the mess that is the VT code by
    > * keeping track if we have the console semaphore held. It's
    >



    \
     
     \ /
      Last update: 2008-06-02 13:53    [W:0.025 / U:0.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site