Messages in this thread | | | Date | Mon, 2 Jun 2008 12:41:50 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 28 May 2008, Abhishek Sagar wrote: > > > > But if irq_enter() has a kretprobe installed on it, the return value stored on the stack at each invocation is modified to divert the return to a kprobe trampoline function called kretprobe_trampoline(). So with this the trace would (currently) look like: > > > > <idle>-0 [00] 4154504455.781616: irq_enter <- kretprobe_trampoline > > > > Now this is quite misleading to the end user, as it suggests something that didn't actually happen. So just to avoid such misinterpretations, the inlined patch aims to output such a log as: > > > > <idle>-0 [00] 4154504455.781616: irq_enter <- [unknown/kretprobe'd] > > > > > > Signed-off-by: Abhishek Sagar <sagar.abhishek@gmail.com> > > Thanks Abhishek, > > Acked-by: Steven Rostedt <srostedt@redhat.com>
applied to tip/tracing/ftrace, thanks.
Ingo
| |