lkml.org 
[lkml]   [2008]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch -v2 01/23] sunrpc: use simple_read_from_buffer
On Mon, Jun 02, 2008 at 08:13:30AM +0900, akinobu.mita@gmail.com wrote:
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> ---
> net/sunrpc/cache.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> Index: 2.6-git/net/sunrpc/cache.c
> ===================================================================
> --- 2.6-git.orig/net/sunrpc/cache.c
> +++ 2.6-git/net/sunrpc/cache.c
> @@ -1271,20 +1271,11 @@ static ssize_t read_flush(struct file *f
> {
> struct cache_detail *cd = PDE(file->f_path.dentry->d_inode)->data;
> char tbuf[20];
> - unsigned long p = *ppos;
> size_t len;
>
> - sprintf(tbuf, "%lu\n", cd->flush_time);
> - len = strlen(tbuf);
> - if (p >= len)
> - return 0;
> - len -= p;
> - if (len > count)
> - len = count;
> - if (copy_to_user(buf, (void*)(tbuf+p), len))
> - return -EFAULT;
> - *ppos += len;
> - return len;
> + len = sprintf(tbuf, "%lu\n", cd->flush_time);
> +
> + return simple_read_from_buffer(buf, count, ppos, tbuf, len);
> }

Please, switch to seq_file:

seq_printf(m, "%lu\n", cd->flush_time);
return 0;

and that's everything module have to worry about.



\
 
 \ /
  Last update: 2008-06-02 07:43    [W:0.112 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site