Messages in this thread | | | Date | Thu, 19 Jun 2008 23:16:17 +0200 | From | Andi Kleen <> | Subject | Re: mce_64.c: mce_cpu_quirks being ignored |
| |
Max Asbock wrote:
> static void __cpuinit mce_cpu_quirks(struct cpuinfo_x86 *c) > { > /* This should be disabled by the BIOS, but isn't always */ > if (c->x86_vendor == X86_VENDOR_AMD) { > if(c->x86 == 15) > /* disable GART TBL walk error reporting, which trips off > incorrectly with the IOMMU & 3ware & Cerberus. */ > clear_bit(10, &bank[4]); > .... > > Is turning off that bit still needed?
Yes it is. Also referencing the bank is needed for other reasons anyways, otherwise it would ignore the user sysfs choice on reconfiguration.
Venki, I did a patch for dynamic banks anyways, but haven't submitted it yet.
-Andi
| |