Messages in this thread | | | From | Nick Piggin <> | Subject | Re: [PATCH][resubmit] x86: enable preemption in delay | Date | Thu, 19 Jun 2008 03:18:07 +1000 |
| |
On Thursday 19 June 2008 02:16, Steven Rostedt wrote: > On Wed, 18 Jun 2008, Nick Piggin wrote: > > There are _some_ cases where it can be used, but nobody has been > > able to come up with compelling uses really. I don't think this > > case is helped very much either because the logic in there using > > preempt-disable is fine, isn't it? > > > > Except that it should also have a cond_resched in it. Seems like > > an ideal place to put cond_resched because it is not a fastpath. > > Does it really need a cond_resched? preempt_enable when it goes to zero > will already check to see if it should schedule.
It doesn't really need one, but of course having one would help non preempt kernels.
| |