lkml.org 
[lkml]   [2008]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BUG: mmapfile/writev spurious zero bytes (x86_64/not i386, bisected, reproducable)

> AFAICS, what happened is that b0rken copy_*FROM*_user() had been discussed
> with references to copy_*TO*_user(). With proposed patch indeed not affecting
> any legitimate calls of the latter. Does affect the former and that, from
> my reading of the code in question, correctly.
>
> IOW, s/copy_to_user/copy_from_user/ in Linus' postings upthread and they
> make sense.

Yes, it makes some more sense, but I'm not completely happy with the fix
because it makes the fault point reporting very unreliable (maximum error
will be 63 instead of 7 now). iirc especially mount was sensitive to that.

Unfortunately fixing the accuracy is a little tricky.

-Andi


\
 
 \ /
  Last update: 2008-06-18 00:25    [from the cache]
©2003-2011 Jasper Spaans