lkml.org 
[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Re: Re: [PATCH 1/6] res_counter: handle limit change
    ----- Original Message -----
    >>> I think when I did all in memcg, someone will comment that "why do that
    >>> all in memcg ? please implement generic one to avoid code duplication"
    >>
    >>Hm... But we're choosing between
    >>
    >>sys_write->xxx_cgroup_write->res_counter_set_limit->xxx_cgroup_call
    >>
    >>and
    >>
    >>sys_write->xxx_cgroup_write->res_counter_set_limit
    >> ->xxx_cgroup_call
    >>
    >>With the sizeof(void *)-bytes difference in res_counter, nNo?
    >>
    >I can't catch what you mean. What is res_counter_set_limit here ?
    >(my patche's ?) and what is sizeof(void *)-bytes ?
    >
    >Is it so strange to add following algorithm in res_counter?
    >==
    >set_limit -> fail -> shrink -> set limit -> fail ->shrink
    >-> success -> return 0
    >==
    >I think this is enough generic.
    >
    This was previous request from Paul. (to hierarchy patch set)

    http://marc.info/?l=linux-mm&m=121257010530546&w=2

    I think this version meets his request. and I like this.

    I don't want to waste more weeks. Then, what is bad ?
    removing res_counter_ops is okay ?

    Thanks,
    -Kame




    \
     
     \ /
      Last update: 2008-06-16 10:57    [W:3.891 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site