lkml.org 
[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch v2 11/16] MMC: S3C24XX: Fix s3c2410_dma_request() return code check.
    The driver should be checking for a negative error code from
    s3c2410_dma_request(), not non-zero. Newer kernels now return
    the DMA channel number that was allocated by the request.

    Signed-off-by: Ben Dooks <ben-linux@fluff.org>

    Index: linux-2.6.26-rc5-q2/drivers/mmc/host/s3cmci.c
    ===================================================================
    --- linux-2.6.26-rc5-q2.orig/drivers/mmc/host/s3cmci.c 2008-06-16 15:25:04.000000000 +0100
    +++ linux-2.6.26-rc5-q2/drivers/mmc/host/s3cmci.c 2008-06-16 15:25:06.000000000 +0100
    @@ -1206,7 +1206,7 @@ static int s3cmci_probe(struct platform_
    s3c2410_gpio_cfgpin(host->pdata->gpio_wprotect,
    S3C2410_GPIO_INPUT);

    - if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL)) {
    + if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL) < 0) {
    dev_err(&pdev->dev, "unable to get DMA channel.\n");
    ret = -EBUSY;
    goto probe_free_irq_cd;
    --
    Ben (ben@fluff.org, http://www.fluff.org/)

    'a smiley only costs 4 bytes'


    \
     
     \ /
      Last update: 2008-06-16 16:55    [W:0.018 / U:209.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site