lkml.org 
[lkml]   [2008]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide_cd_pad_transfer
Date
On Thursday 12 June 2008, Borislav Petkov wrote:
> Use the generic ide_pad_transfer() helper instead
>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>

applied w/ ide_cd_drain_data() -> ide_pad_transfer() conversion fixup

[...]

> @@ -1006,7 +981,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> - bio_cur_sectors(rq->bio),
> thislen >> 9);
> if (nskip > 0) {
> - ide_cd_drain_data(drive, nskip);
> + ide_pad_transfer(drive, write, nskip);
> rq->current_nr_sectors -= nskip;
> thislen -= (nskip << 9);
> }

ide_cd_drain_data() took number for _sectors_ as an argument
while ide_pad_transfer() wants to be given number of _bytes_

> @@ -1043,7 +1018,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> * If the buffers are full, pipe the rest into
> * oblivion.
> */
> - ide_cd_drain_data(drive, thislen >> 9);
> + ide_pad_transfer(drive, 0, thislen >> 9);

ditto


\
 
 \ /
  Last update: 2008-06-14 19:51    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog