lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 08/47] ecryptfs: add missing lock around notify_change
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Miklos Szeredi <mszeredi@suse.cz>

    upstream commit: 9c3580aa52195699065bc2d7242b1c7e3e6903fa

    Callers of notify_change() need to hold i_mutex.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    Cc: Michael Halcrow <mhalcrow@us.ibm.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    fs/ecryptfs/inode.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/ecryptfs/inode.c
    +++ b/fs/ecryptfs/inode.c
    @@ -908,7 +908,9 @@ static int ecryptfs_setattr(struct dentr
    if (ia->ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID))
    ia->ia_valid &= ~ATTR_MODE;

    + mutex_lock(&lower_dentry->d_inode->i_mutex);
    rc = notify_change(lower_dentry, ia);
    + mutex_unlock(&lower_dentry->d_inode->i_mutex);
    out:
    fsstack_copy_attr_all(inode, lower_inode, NULL);
    return rc;
    --


    \
     
     \ /
      Last update: 2008-06-14 02:17    [W:4.270 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site