Messages in this thread | | | Subject | Re: [PATCH 3/5] mutex debug: add generic blocked_on usage | From | Daniel Walker <> | Date | Thu, 12 Jun 2008 06:21:31 -0700 |
| |
On Thu, 2008-06-12 at 07:25 +0200, Peter Zijlstra wrote: > On Wed, 2008-06-11 at 13:49 -0700, Daniel Walker wrote: > > plain text document attachment (blocked_on-mutex.patch) > > > -#ifdef CONFIG_DEBUG_MUTEXES > > - /* mutex deadlock detection */ > > - struct mutex_waiter *blocked_on; > > -#endif > > + /* > > + * Deadlock detection and priority inheritance handling, > > + * and any other out of line mutex operations > > + */ > > + struct lock_waiter_state *blocked_on; > > Now you grew task_struct unconditionally, how about > > #if defined CONFIG_DEBUG_MUTEX || defined CONFIG_RT_MUTEXES || defined CONFIG_FUTEX > > ?
Ok .. I didn't add it cause I wasn't convinced RT_MUTEXES was optional .. There's a lot of PI futex related code that isn't ifdef'd either..
Daniel
| |