lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] mutex debug: add generic blocked_on usage
From
Date

On Thu, 2008-06-12 at 07:25 +0200, Peter Zijlstra wrote:
> On Wed, 2008-06-11 at 13:49 -0700, Daniel Walker wrote:
> > plain text document attachment (blocked_on-mutex.patch)
>
> > -#ifdef CONFIG_DEBUG_MUTEXES
> > - /* mutex deadlock detection */
> > - struct mutex_waiter *blocked_on;
> > -#endif
> > + /*
> > + * Deadlock detection and priority inheritance handling,
> > + * and any other out of line mutex operations
> > + */
> > + struct lock_waiter_state *blocked_on;
>
> Now you grew task_struct unconditionally, how about
>
> #if defined CONFIG_DEBUG_MUTEX || defined CONFIG_RT_MUTEXES || defined CONFIG_FUTEX
>
> ?

Ok .. I didn't add it cause I wasn't convinced RT_MUTEXES was
optional .. There's a lot of PI futex related code that isn't ifdef'd
either..

Daniel



\
 
 \ /
  Last update: 2008-06-12 15:23    [W:0.050 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site