lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/23] checkpatch: check spacing for square brackets
    Date
    Check on the spacing before square brackets.  We should only allow spaces
    there if this is part of a type definition or an initialialiser.

    Signed-off-by: Andy Whitcroft <apw@shadowen.org>
    ---
    scripts/checkpatch.pl | 11 +++++++++++
    1 files changed, 11 insertions(+), 0 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 5f71b30..e7c8ab1 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1435,6 +1435,17 @@ sub process {
    ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
    }

    +# check for spacing round square brackets; allowed:
    +# 1. with a type on the left -- int [] a;
    +# 2. at the beginning of a line for slice initialisers -- [0..10] = 5,
    + while ($line =~ /(.*?\s)\[/g) {
    + my ($where, $prefix) = ($-[1], $1);
    + if ($prefix !~ /$Type\s+$/ &&
    + ($where != 0 || $prefix !~ /^.\s+$/)) {
    + ERROR("space prohibited before open square bracket '['\n" . $herecurr);
    + }
    + }
    +
    # check for spaces between functions and their parentheses.
    while ($line =~ /($Ident)\s+\(/g) {
    my $name = $1;
    --
    1.5.6.rc0.140.ga9675


    \
     
     \ /
      Last update: 2008-06-12 14:33    [W:0.022 / U:0.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site