lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/23] checkpatch: possible modifiers are not being correctly matched
    Date
    Although we are finding the added modifier in the declaration below
    we are not correctly matching it as a type. Fix the declaration.

    static void __ref *vmem_alloc_pages(unsigned int order)
    {
    }

    Signed-off-by: Andy Whitcroft <apw@shadowen.org>
    ---
    scripts/checkpatch.pl | 7 +++----
    1 files changed, 3 insertions(+), 4 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 077a2ca..53ec394 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -168,12 +168,11 @@ our @modifierList = (
    );

    sub build_types {
    - my $mods = "(?: \n" . join("|\n ", @modifierList) . "\n)";
    - my $all = "(?: \n" . join("|\n ", @typeList) . "\n)";
    + my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
    + my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
    $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
    $NonptrType = qr{
    - (?:const\s+)?
    - (?:$mods\s+)?
    + (?:$Modifier\s+|const\s+)*
    (?:
    (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
    (?:${all}\b)
    --
    1.5.6.rc0.140.ga9675


    \
     
     \ /
      Last update: 2008-06-12 14:31    [W:0.022 / U:0.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site