lkml.org 
[lkml]   [2008]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 11/24] pageflag helpers for configed-out flags
    On Wed, 11 Jun 2008 16:43:01 -0400
    Lee Schermerhorn <Lee.Schermerhorn@hp.com> wrote:

    > On Wed, 2008-06-11 at 16:32 -0400, Rik van Riel wrote:
    > > On Wed, 11 Jun 2008 16:28:03 -0400
    > > Lee Schermerhorn <Lee.Schermerhorn@hp.com> wrote:
    > > > On Wed, 2008-06-11 at 13:01 -0700, Andrew Morton wrote:
    > > > > On Wed, 11 Jun 2008 14:42:25 -0400
    > > > > Rik van Riel <riel@redhat.com> wrote:
    > > > >
    > > > > > Define proper false/noop inline functions for noreclaim page
    > > > > > flags when !defined(CONFIG_NORECLAIM_LRU)
    > > > >
    > > > > I changed that to CONFIG_UNEVICTABLE_LRU.
    > > >
    > > > I noticed that the vmstat items [perhaps these will go away] still use
    > > > "noreclaim".
    > >
    > > $ cat /proc/vmstat
    > > nr_free_pages 3887198
    > > nr_inactive_anon 5043
    > > nr_active_anon 2182
    > > nr_inactive_file 67121
    > > nr_active_file 49045
    > > nr_unevictable 0
    > > nr_mlock 0
    > >
    > > Or am I looking at the wrong thing?
    >
    > Do you have patch 21/24 applied? In 26-rc5-mm1, I see the
    > noreclaim_pgs_* vmstat items. They're in the patch 21 you just posted,
    > as well.

    Doh!

    I am working against:

    http://userweb.kernel.org/~akpm/mmotm/

    You may want to send Andrew an update against patch 21/24 that
    changes those names from noreclaim_pgs_* to unevictable_pgs_*.

    > Again, we might decide to drop that patch from the merge. I found the
    > stats useful during debug and test, but I don't know that they provide
    > any value in the longer term.

    That's an option too. I'll let you and Kosaki-san decide on
    that, since I had relatively little involvement with the
    second half of the patch series recently.

    --
    All rights reversed.


    \
     
     \ /
      Last update: 2008-06-11 22:51    [W:0.041 / U:0.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site