Messages in this thread | | | Date | Wed, 11 Jun 2008 20:48:59 +0200 | From | Andrea Righi <> | Subject | Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5) |
| |
Balbir Singh wrote: > Andrea Righi wrote: >> Balbir Singh wrote: >>> +static int memrlimit_cgroup_write_strategy(char *buf, unsigned long >>> long *tmp) >>> +{ >>> + *tmp = memparse(buf, &buf); >>> + if (*buf != '\0') >>> + return -EINVAL; >>> + >>> + *tmp = PAGE_ALIGN(*tmp); >>> + return 0; >>> +} >> We shouldn't use PAGE_ALIGN() here, otherwise we limit the address space >> to 4GB on 32-bit architectures (that could be reasonable, because this >> is a per-cgroup limit and not per-process). >> > > You mean un-reasonable?
well... I mean, there would be no reason to apply this fix if it was a limit per-task on 32-bit. ;-)
-Andrea
| |