Messages in this thread | | | Date | Wed, 11 Jun 2008 11:23:54 +0530 | From | "Abhishek Sagar" <> | Subject | Re: [PATCH] kprobes: remove redundant config check |
| |
On 6/11/08, Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote: > Abhishek, > > This was intentional (to take care of some gcc 4.2 issues). See commit > cd5bfea278987ebfe60f3ff92a01696b17c4f978 (fix compilation with gcc 4.2) > from Peter Chubb for details.
Yea, I checked it out and the problem the commit seems to be fixing is that EXPORT_SYMBOL complains for static symbols with gcc-4.2. Can't see why there was a need to cram CONFIG_KPROBES inside kprobes.c. This check was sneaked in defensively it seems, and is unnecessary.
-- Regards, Abhishek Sagar
| |