Messages in this thread | | | Date | Wed, 11 Jun 2008 00:15:54 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk |
| |
On 06/11/2008 12:14 AM, Philippe De Muyter wrote: > On Tue, Jun 10, 2008 at 11:51:21PM +0200, Jiri Slaby wrote: >> On 06/10/2008 11:42 PM, Philippe De Muyter wrote: >>> Hello everybody, >>> In the cirrusfb driver, the RAM address printk has a superfluous 'x' >>> that could be interpreted as "don't care", while it is actually a typo. >>> Fix that. >>> Signed-off-by: Philippe De Muyter <phdm@macqel.be> >>> diff -r 184e1bb486cf drivers/video/cirrusfb.c >>> --- a/drivers/video/cirrusfb.c Mon Jun 9 19:30:13 2008 -0700 >>> +++ b/drivers/video/cirrusfb.c Tue Jun 10 13:25:22 2008 +0200 >>> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct >>> info->screen_size = board_size; >>> cinfo->unmap = cirrusfb_pci_unmap; >>> - printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ", >>> + printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ", >>> info->screen_size >> 10, board_addr); >> Hmm, is there \n missing too? >> > > No that would make the RAM adress orphan, but we must also remove KERN_INFO > in the printk below.
No please. This makes logs non-atomic. Make one printk from the two.
>>> printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n"); >>> pci_set_drvdata(pdev, info);
| |