lkml.org 
[lkml]   [2008]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 11/11] GRU Driver - makefile & Kconfig file changes
On Mon, Jun 09, 2008 at 02:35:09PM -0700, Roland Dreier wrote:
> > +EXTRA_CFLAGS += -DDEBUG -Werror -Wall
>
> Not sure if it's appropriate to set these flags for your driver...

Deleted. This was primarily for debugging. I moved the DEBUG option to
Kconfig as a driver DEBUG option that can be selected.


>
> > + ---help---
> > + This option enables basic support for the SGI UV GRU driver. If
> > + you are not running on a SGI UV system, say N.
>
> "...enables basic support for the SGI UV GRU." And it would be a good
> idea to include some info about what UV GRU does -- your 0/11
> introduction mail had a good description that would be nice to have here
> as well.

Done


--- jack


\
 
 \ /
  Last update: 2008-06-10 16:45    [W:0.047 / U:5.344 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site